Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the interchange be provided by the runner #100

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Make the interchange be provided by the runner #100

wants to merge 8 commits into from

Conversation

sosthene-nitrokey
Copy link
Contributor

This allows for more flexibility. Ultimately the goal it to enable running multiple trussed instances at the same time.

@robin-nitrokey
Copy link
Member

Please don’t remove the StoreProvier::ifs function. It is needed to setup the provisioner app in our usbip runner. https://github.com/Nitrokey/nitrokey-3-firmware/blob/5ecad2efb1fc07dfc27b24686ce36d49dd59976c/runners/usbip/src/main.rs#L196

@sosthene-nitrokey sosthene-nitrokey force-pushed the interchange-runner branch 2 times, most recently from 3791212 to 2bbe4cc Compare February 22, 2023 16:48
@sosthene-nitrokey
Fix pipe tests
8fdeefd 
I don't really understand why the size is that high.
The size of the `Message` struct is 2416.
The channel is a message in an unsafecell + 1 atomicU8 and 2 atomic bools.
It should only 3 more bytes but for some reason it's 16
@sosthene-nitrokey sosthene-nitrokey mentioned this pull request Mar 31, 2023
Open
@sosthene-nitrokey
Copy link
Contributor Author

I think there's a better solution that doesn't require lifetimes everywhere. If we make Service::process take as input an array of Responder, it doesn't need to own them any more. There would be some more lifetimes in process but those would be elided very easily.

@sosthene-nitrokey sosthene-nitrokey marked this pull request as draft April 6, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sosthene-nitrokey @robin-nitrokey